Release - March 2018 - Target RC date: 2018-03-01 - name: 0.12.0

[dslomov]

No description provided.

[dslomov]

@philwo lmk if you are unavailable on those dates

[philwo]

@dslomov Should work fine for me :)

[or-shachar]

Hey fellows! Do we have an updated date for this RC?

[philwo]

The current baseline looks pretty good. I'll likely cut an RC today.

[philwo]

We should investigate whether we should point this out in the release notes, in case others have the same issue:

tensorflow/tensorflow#17508

[laszlocsomor]

@philwo: would it be possible to wait for #4806 ?

[laszlocsomor]

Thanks @philwo for waiting! My PR was merged as b961b0a, I'd love to have this in the RC.

[laszlocsomor]

Also, note to self and to @philwo: I'd like to write about b961b0a in the release notes.

[philwo]

This looks like a good baseline to me: b33e5af

[philwo]

$ scripts/release/release.sh create 0.12.0 b33e5afa313322a7048044c44d854cbb666b988e
$ scripts/release/release.sh push

[philwo]

Release candidate 1 has been successfully cut, branch has been pushed (https://github.com/bazelbuild/bazel/tree/release-0.12.0) and I managed to convince Buildkite to build our release artifacts with the correctly embedded version number:

https://buildkite.com/bazel/release/builds/20

Tomorrow I'll work on the release scripts to finish the Buildkite support and will then do the rest of the release process (verifying produced artifacts, signing, pushing to GCS / APT repository / GitHub and sending the announcement mail).

[philwo]

This seems like a potential release blocker: #4846

[laszlocsomor]

#4734 is also a potential blocker, though I doubt it's a regression.

[laszlocsomor]

@philwo : where can we download the RC1 binary?

[laszlocsomor]

Another possible blocker: #4847
I'm looking for its culprit now.

[philwo]

@laszlocsomor You can download the binaries here: https://buildkite.com/bazel/release/builds/20 (check the "Artifacts" tab for each platform).

I'm right now working on getting it out via the usual channels as well.

[laszlocsomor]

Please cherrypick 3694099 to fix #4847.

[philwo]

I got the release stuff working at last and just sent out the announcement to bazel-discuss@. Binaries are available on our website and via apt-get in the testing branch.

Note that I had to rebuild the binaries one more time, because the release notes embedded in the installers were wrong due to an error in the release pipeline script. If you downloaded the binaries from the above Buildkite link, please don't be surprised. There were no functional changes and both the binaries above and the ones in the announcement I just sent out were built from the exact same Git commit. :)

[cushon]

@philwo can you cherry-pick dbf7798 for #4846?

[laszlocsomor]

@philwo please cherrypick 4c3098c to fix #4734

[steeve]

Please cherry-pick #4866, fixes Android's libc++

[laszlocsomor]

Please cherry-pick b1be581 to fix #4879, and also remove the following "New features" relnotes entry: "python,runfiles: You can now ..."

[philwo]

Trying to create 0.12.0rc2 now:

$ scripts/release/release.sh create 0.12.0 b33e5afa313322a7048044c44d854cbb666b988e \
  369409995bd75eeb0683fd24f7585d2a90320796 \
  dbf779869751cc893ba240402d352c6e70be2978 \
  4c3098cfa6f00f90c7530b6f40d3e93062931c1d \
  a1068c44a700ec2cff84cbd12592e9bfea25d754 \
  b1be5816ec1bf8e1172c1bed4f29b4e6c6bb7202 \
  0a4622012ff796429220fe57d3217f262cc208a8 \
  3c5373c50c7c492842f8a468906eda2c0bc90787

[philwo]

Will also cherrypick @meteorcloudy's 0a46220 and 3c5373c

[philwo]

$ scripts/release/release.sh push

[ittaiz]

@philwo rc2 will include the junit fix, right? (Meaning you won’t cherry pick the revert)

…

On Wed, 21 Mar 2018 at 17:41 Philipp Wollermann ***@***.***> wrote: $ scripts/release/release.sh push — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIFxPlGsUeo2unDtR5YvYZffY-Y2SFks5tgnSsgaJpZM4R5mrb> .

[philwo]

@ittaiz The revert hasn't been cherrypicked, so rc2 should be fine. :)

[ittaiz]

Thanks!

…

On Wed, 21 Mar 2018 at 18:21 Philipp Wollermann ***@***.***> wrote: @ittaiz <https://github.com/ittaiz> The revert hasn't been cherrypicked, so rc2 should be fine. :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF-vpPDg5_RCHbzX2740Mz1Ss3uIsks5tgn4FgaJpZM4R5mrb> .

[philwo]

0.12.0rc2 pushed: https://releases.bazel.build/0.12.0/rc2/index.html

[philwo]

Last known release blocker:

• Bazel 0.12.0 rc2: Remote caching failed on Windows #4904

[laszlocsomor]

I just noticed this entry in the release notes:

New features:

...

• The new "--local_tmp_root=" flag allows specifying the temp
  directory for locally executed actions.

Please remove it, the feature was rolled back in cfe5994.

[philwo]

FYI, the Bazel release 0.12.0 will be delayed until April 9th due to one remaining release blocker and me being on vacation from tomorrow. I think that's better than rushing it out today only to find out that there's an issue and then I'm not there to fix it :)

Bazel 0.12.0rc2 should be pretty much what goes out as final, as I'm not aware of any other known issues, except for the remote caching on Windows issue (#4904).

[ittaiz]

Will this mean 0.13.0 will also be delayed?

…

On Thu, Mar 29, 2018 at 10:09 AM Philipp Wollermann < ***@***.***> wrote: FYI, the Bazel release 0.12.0 will be delayed until April 9th due to one remaining release blocker and me being on vacation from tomorrow. I think that's better than rushing it out only to find out that there's an issue and then I'm not there to fix it :) Bazel 0.12.0rc2 should be pretty much what goes out as final, as I'm not aware of any other known issues, except for the remote caching on Windows issue (#4904 <#4904>). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIFw17rglThhK8a8QYwTH5CBWQQAbWks5tjIibgaJpZM4R5mrb> .

[philwo]

@ittaiz I think we can cut 0.13.0-rc1 as planned.

[petemounce]

0.12.0-rc1 and rc2 have been pushed to chocolatey.

[xingao267]

I'm seeing TF build failure with version >= Bazel 0.12.0rc2 both locally and remotely. Please take a look at tensorflow/tensorflow#17816.

[philwo]

I'm creating rc3 now with the additional cherrypick f54d7e5 to fix #4904.

Thanks @meteorcloudy!

[philwo]

Bazel 0.12.0rc3 has been pushed.

https://groups.google.com/d/msg/bazel-discuss/j7ozGl-I7oE/PsdytIfyBwAJ
https://releases.bazel.build/0.12.0/rc3/index.html

Tentative release date is Wednesday if we don't find any blockers.

[philwo]

We have three failures on a full downstream test run (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/193):

• rules_docker: Rules docker red on bazel ci rules_docker#363
• rules_python: Tests failing on Bazel CI rules_python#67
• TensorFlow Serving: Update TF commit to fix tensorflow_serving with Bazel@HEAD tensorflow/serving#825

Considering that fixes are available upstream and just not merged yet, I don't consider these a blocker.

[meteorcloudy]

Just confirmed with @xingao267 , tensorflow/tensorflow#17816 is also not a regression.
I tested remote cache on Windows with TensorFlow, it also worked. I think rc3 looks quite good!

[petemounce]

rc3 is on chocolatey.

[steeve]

Can we cherry-pick cb16c50 please pretty please ?

[philwo]

@steeve I'm releasing 0.12.0 and cannot add any more cherry-picks... sorry! But 0.13.0 is just around the corner. Please ping its release bug regarding this: #4583 :)

[steeve]

Sure thing, thank you !

[petemounce]

0.12.0 is up on chocolatey. Apologies for delay!

[philwo]

Thank you @petemounce :)