java,runfiles: the runfiles library should not pick up TEST_SRCDIR

[laszlocsomor]

Description of the problem / feature request:

The new java runfiles library in @bazel_tools//tools/runfiles, coming out with Bazel 0.11.0, should not pick up $TEST_SRCDIR when neither $RUNFILES_MANIFEST_FILE nor $RUNFILES_DIR is defined. In case a test runs Bazel to build and run a mock java_binary that uses the new runfiles library, the binary should not pick up the test's $TEST_SRCDIR but find its own runfiles insated.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

1. Cherry-pick https://bazel-review.googlesource.com/c/bazel/+/37210 into a Bazel repo:

   git checkout master
   git checkout -b bug-repro
   git fetch https://bazel.googlesource.com/bazel refs/changes/10/37210/1 && git cherry-pick FETCH_HEAD
   

2. bazel test //src/test/py/bazel:runfiles_test

   This fails.

3. Now add the bugfix, and run the test again:

   git reset --hard HEAD~1
   git fetch https://bazel.googlesource.com/bazel refs/changes/10/37210/1 && git checkout FETCH_HEAD
   bazel test //src/test/py/bazel:runfiles_test
   

   The test should now pass.

What operating system are you running Bazel on?

Debian testing.

What's the output of bazel info release?

  $ bazel info release
release 0.11.0rc1

Any other information, logs, or outputs that you want to share?

This is blocking #3959.
https://bazel-review.googlesource.com/c/bazel/+/37190 will fix it.

[laszlocsomor]

Ironically this bug does not affect Bazel on Windows, because the native launcher we use for xx_binary rules sets RUNFILES_MANIFEST_{FILE,PATH} and RUNFILES_DIR.

[laszlocsomor]

Fixed by: d855d81

Pending change https://bazel-review.googlesource.com/c/bazel/+/37210 will add a test.