Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: output_root default should not be in TMP #5038

Closed
laszlocsomor opened this issue Apr 17, 2018 · 3 comments
Closed

Windows: output_root default should not be in TMP #5038

laszlocsomor opened this issue Apr 17, 2018 · 3 comments
Assignees
@laszlocsomor
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

Read bazelbuild/continuous-integration#252 (comment) and following 5 comments.

TL;DR: If anything deletes your $TMP that's not aware of junctions and your outputroot is under the $TMP, then the external repo junctions and every junction pointing to places all over the filesystem will have files deleted from them.

Immediate solution: use GetHomeDir() instead of $TMP.

What operating system are you running Bazel on?

All windows versions.

What's the output of bazel info release?

0.12.0

Have you found anything relevant by searching the web?

Related: bazelbuild/continuous-integration#252
@laszlocsomor
Copy link
Contributor Author

/cc @jasharpe @meteorcloudy @dslomov

@laszlocsomor laszlocsomor self-assigned this Apr 17, 2018
@laszlocsomor laszlocsomor added type: bug P0 This is an emergency and more important than other current work. (Assignee required) platform: windows release blocker labels Apr 17, 2018
@laszlocsomor laszlocsomor mentioned this issue Apr 17, 2018
Closed
@laszlocsomor
Copy link
Contributor Author

Blocking #4583.

@laszlocsomor laszlocsomor added P1 I'll work on this now. (Assignee required) and removed P0 This is an emergency and more important than other current work. (Assignee required) labels Apr 17, 2018
@laszlocsomor
Copy link
Contributor Author

OK, P0 was too much:

  • there's a simple workaround: use the --output_user_root flag
  • this bug affects every Bazel version, but it's rare

P1 though because it is bad enough.

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 17, 2018
@laszlocsomor
windows: GetOutputRoot() returns GetHomeDir()
38af304 
This is an immediate fix for a very nasty bug:
bazelbuild#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
@laszlocsomor laszlocsomor mentioned this issue Apr 17, 2018
Closed
bazel-io pushed a commit that referenced this issue Apr 18, 2018
@laszlocsomor
windows: GetOutputRoot() returns GetHomeDir()
f083e76 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
@laszlocsomor laszlocsomor mentioned this issue Apr 18, 2018
Closed
meteorcloudy pushed a commit that referenced this issue Apr 19, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
4b9e096 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this issue Apr 24, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
b088001 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this issue Apr 26, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
4d269d7 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this issue Apr 26, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
a18b11e 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
meteorcloudy pushed a commit that referenced this issue May 7, 2018
@laszlocsomor @meteorcloudy
windows: GetOutputRoot() returns GetHomeDir()
8812669 
This is an immediate fix for a very nasty bug:
#5038

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb

Closes #5039.

Change-Id: I5e4f9fa13e5ac785514bc0dc4ce6cba9a88f33bb
PiperOrigin-RevId: 193315571
This was referenced May 15, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laszlocsomor