Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation does not list all attribute types #5362

Closed
ash2k opened this issue Jun 11, 2018 · 2 comments
Closed

Documentation does not list all attribute types #5362

ash2k opened this issue Jun 11, 2018 · 2 comments
Assignees
@laszlocsomor
Labels
type: bug type: documentation (cleanup)

Comments

@ash2k
Copy link
Contributor

ash2k commented Jun 11, 2018

Description of the problem / feature request:

https://docs.bazel.build/versions/master/build-ref.html#rules says:

The full set of types that an attribute can have is: integer, label, list of labels, string, list of strings, output label, list of output labels

But there are quite a few more types that are available: https://docs.bazel.build/versions/master/skylark/lib/attr.html#modules.attr
@laszlocsomor
Copy link
Contributor

Thanks! If you feel like fixing it, here's the source for the doc file: https://github.com/bazelbuild/bazel/blob/master/site/docs/build-ref.html

@laszlocsomor laszlocsomor added type: bug type: documentation (cleanup) P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) labels Jun 11, 2018
@laszlocsomor
Copy link
Contributor

(Otherwise someone else will fix it later.)

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Jun 11, 2018
@laszlocsomor
docs: don't list all attribute types in build-ref
c031403 
Fixes bazelbuild#5362

Change-Id: I41d7b78e8d31d4a08ba0aba35c81723cbb315c40
@laszlocsomor laszlocsomor self-assigned this Jun 11, 2018
@laszlocsomor laszlocsomor mentioned this issue Jun 11, 2018
Closed
ArielleA pushed a commit to ArielleA/bazel that referenced this issue Jun 19, 2018
@laszlocsomor @ArielleA
docs: don't list all attribute types in build-ref
605e8ee 
Fixes bazelbuild#5362

Change-Id: I41d7b78e8d31d4a08ba0aba35c81723cbb315c40

Closes bazelbuild#5364.

Change-Id: I41d7b78e8d31d4a08ba0aba35c81723cbb315c40
PiperOrigin-RevId: 200182384
werkt pushed a commit to werkt/bazel that referenced this issue Aug 2, 2018
@laszlocsomor
docs: don't list all attribute types in build-ref
c50fbc5 
Fixes bazelbuild#5362

Change-Id: I41d7b78e8d31d4a08ba0aba35c81723cbb315c40

Closes bazelbuild#5364.

Change-Id: I41d7b78e8d31d4a08ba0aba35c81723cbb315c40
PiperOrigin-RevId: 200182384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
type: bug type: documentation (cleanup)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ash2k @laszlocsomor