Release - September 2018 - name: 0.18.0 #5963

laurentlb · 2018-08-22T20:12:50Z

@aehlig Can you take care of the release 0.18.0?

aehlig · 2018-08-23T09:57:01Z

@aehlig Can you take care of the release 0.18.0?

I can take care of 0.18.0, provided it is OK that the baseline will be cut a bit late: I'm on vacation September 1--8. But given that 0.17.0 is delayed anyway, this should be fine.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

laurentlb · 2018-08-23T10:59:11Z

Sounds good, we can target September 10 or 11.

hlopko · 2018-09-03T14:45:49Z

It's actually awesome, because I can finish my incompatible flags cls :)))

laszlocsomor · 2018-09-03T16:29:04Z

Potential blocker: #6061
(Need to verify if 0.18.* is affected or whether the bug is a regression.)

Update(2018-09-10): verified that this is not a blocker.

aehlig · 2018-09-10T14:19:36Z

Looking through the last nighly builds and tests of downstream projects, the most promising baseline seems to be 2e7ccbe @laszlocsomor, this baseline also includes the update of protobuf to 3.6.1; do I understand correctly, that this resolves your potential release blocker?

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

laszlocsomor · 2018-09-10T14:30:20Z

@aehlig : Yes, that commit is beyond ddc97ed so #6061 is not a blocker. Thanks for checking!

laszlocsomor · 2018-09-10T14:32:51Z

Another potential blocker: #6099
I'll test the RC to see if it's affected.

aehlig · 2018-09-10T14:40:57Z

Creating 0.18.0rc1, baseline 2e7ccbe, no cherry picks.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

laurentlb · 2018-09-10T14:53:11Z

Some cherrypicks of 0.17 are not included in your baseline.

hlopko · 2018-09-10T14:53:54Z

Please consider picking a later baseline, since we decided to follow https://docs.bazel.build/versions/master/skylark/backward-compatibility.html quite late, we rushed to submit needed cls:

@scentini to verify I didn't miss anything

aehlig · 2018-09-10T16:00:51Z

0.18.0rc1 is available at https://releases.bazel.build/0.18.0/rc1/index.html Will create another RC with the cherry-picks that went into 0.17.1 but are not in the baseline soon.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

aehlig · 2018-09-10T16:17:45Z

Some cherrypicks of 0.17 are not included in your baseline.

According to the logs on #5059, we're talking about 9323c57 7eb9ea1 4566a42 1e9f0aa a572c1c 29f1de0 Is this correct? Will also check if tomorrow's nighly is suitable as a base line. If not, I will try to add those cherry-picks on the current base line.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

lberki · 2018-09-10T16:20:12Z

/cc @cushon

cushon · 2018-09-10T16:45:07Z

@lberki are you planning to include 7eb9ea1 in 0.18 too?

cushon · 2018-09-10T21:06:10Z

@aehlig can you cherry-pick c6eef5d for #6105?

lberki · 2018-09-11T07:19:42Z

@mhlopko is informing me that there will be a new baseline

aehlig · 2018-09-11T08:37:55Z

Will also check if tomorrow's nighly is suitable as a base line.

Looks good. The only thing we have to look at is what's going on with Gerrit and jdk9 as this might be bazel related.

So, let's push the baseline forward to c062b1f instead of starting with too many cherry-picks right from the beginning.

hlopko · 2018-09-11T08:40:40Z

Fantastic, thanks Klaus!

davido · 2018-09-11T09:30:38Z

The only thing we have to look at is what's going on with Gerrit and jdk9 as this might be bazel related.

Can you share the logs?

aehlig · 2018-09-11T09:59:34Z

> The only thing we have to look at is what's going on with Gerrit and jdk9 Can you share the logs?

The first error message is ``` ERROR: /var/lib/buildkite-agent/builds/buildkite-worker-ubuntu1804-java9-lfqk-1/bazel-downstream-projects/gerrit/java/com/google/gerrit/index/BUILD:8:1: Couldn't build file java/com/google/gerrit/index/libquery_exception-hjar.jar: Compiling Java headers java/com/google/gerrit/index/libquery_exception-hjar.jar (2 files) failed (Exit 1) An exception has occurred in turbine. java.lang.IllegalArgumentException: Could not find java.lang on bootclasspath at com.google.turbine.binder.Binder.bindPackages(Binder.java:170) at com.google.turbine.binder.Binder.bind(Binder.java:94) at com.google.turbine.main.Main.compile(Main.java:97) at com.google.devtools.build.java.turbine.Turbine.compile(Turbine.java:76) at com.google.devtools.build.java.turbine.Turbine.compile(Turbine.java:69) at com.google.devtools.build.java.turbine.Turbine.main(Turbine.java:46) ``` This only occurs on JDK9, and Gerrit is the only project we test with JDK9. A potentially related commit is c1d8776. @cushon, can you have a look as well? Thanks.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

aehlig · 2018-09-11T10:00:15Z

rc2 is available at https://releases.bazel.build/0.18.0/rc2/index.html

Please test!

davido · 2018-09-11T10:03:00Z

@aehlig Thanks, I see that @meteorcloudy already created extra issue for this breakage.

aehlig · 2018-09-11T10:07:09Z

Thanks, I see that @meteorcloudy already created extra issue for this breakage.

This is #6127.

lberki · 2018-09-11T19:39:54Z

...aand, the first cherrypick request: 2834613 to fix #6060 (a regression between 0.16 and 0.16.1, still in 0.17)

dslomov · 2018-10-05T20:22:05Z

rc9 is created using

scripts/release/release.sh create --force_rc=9 0.18.0 c062b1f 2834613 2579b79 faaff7f b073a18 bf6a63d c1a7b4c 71926bc 86a8217

It is available on https://releases.bazel.build/0.18.0/rc9/index.html

petemounce · 2018-10-08T21:46:45Z

rc-4-9 pushed to chocolatey.

sdqali · 2018-10-10T17:43:25Z

Thank you for taking on this release. When can we expect this to be out?

aehlig · 2018-10-10T21:51:13Z

Thank you for taking on this release. When can we expect this to be out?

My plan was to release on Monday, unless more issues are reported.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

hlopko · 2018-10-15T07:45:52Z

I'm not sure what the process is, so just to be sure I'll say that I'll perform an incompatible change flip (#6380) in 0.19, so 0.18 should probably mention it as an incoming incompatible change. Or not, if we're not yet doing the new process.

laurentlb · 2018-10-15T07:54:14Z

To suggest changes to the announcement, see: https://docs.google.com/document/d/1wDvulLlj4NAlPZamdlEVFORks3YXJonCjyuQMUQEmB0/edit

hlopko · 2018-10-15T07:56:53Z

That sounds like something I should have done instead spamming this thread :) Thanks Laurent :)

aehlig · 2018-10-15T08:23:46Z

As there are no new blockers, releasing now.

aehlig · 2018-10-15T08:45:14Z

https://github.com/bazelbuild/bazel/releases/tag/0.18.0

petemounce · 2018-10-15T20:16:43Z

Pushed to chocolatey.

laurentlb · 2018-10-16T19:20:46Z

I think we need a patch release 0.18.1 to fix #6292.

meteorcloudy · 2018-10-17T07:59:30Z

We need to cherry-pick 914b4ce for #6292

aehlig · 2018-10-22T17:08:51Z

On Wed, Oct 17, 2018 at 12:59:50AM -0700, Yun Peng wrote: We need to cherry-pick 914b4ce for #6292

Unfortunately, this is not a clean cherry-pick for 0.18.0. Cherry-picking 914b4ce on top of 0.18.0 conflicts with the changes by aaba6fe which is after the base line for 0.18.0. @meteorcloudy, please provide guidance on how you want this patch backported to 0.18.0.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

meteorcloudy · 2018-10-23T09:19:33Z

@aehlig Thanks for dealing with this.

Can you just make sure

      if (ccToolchain(ruleContext).supportsInterfaceSharedObjects()) {
        ccLinkingHelper.emitInterfaceSharedObjects(true);
      }

is added after CcLinkingHelper ccLinkingHelper = initializeLinkingHelper(featureConfiguration, deps);
in CcProtoAspect.java?

aehlig · 2018-10-23T11:16:29Z

@aehlig Thanks for dealing with this. Can you just make sure ``` if (ccToolchain(ruleContext).supportsInterfaceSharedObjects()) { ccLinkingHelper.emitInterfaceSharedObjects(true); } ``` is added after `CcLinkingHelper ccLinkingHelper = initializeLinkingHelper(featureConfiguration, deps);` in CcProtoAspect.java?

The line `CcLinkingHelper ccLinkingHelper = initializeLinkingHelper(featureConfiguration, deps);` does not exist in `CcProtoAspect.java` of 0.18.0. Created `0.18.1rc1` as discussed in person with @meteorcloudy.

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

aehlig · 2018-10-24T11:26:33Z

Created `0.18.1rc1` as discussed in person with @meteorcloudy.

After a couple of attempts to backport 914b4ce correctly, finally arrived at `0.18.1rc3`, see https://releases.bazel.build/0.18.1/rc3/index.html Please test carefully!

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

aehlig · 2018-10-24T13:47:01Z

On Wed, Oct 24, 2018 at 01:26:23PM +0200, Klaus Aehlig wrote: > Created `0.18.1rc1` as discussed in person with @meteorcloudy. After a couple of attempts to backport 914b4ce correctly, finally arrived at `0.18.1rc3`, see https://releases.bazel.build/0.18.1/rc3/index.html Please test carefully!

This rc fails for the "no JDK" case. The internal CI link is https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/532#3668026f-a0e0-4d06-ad82-d9d88367347c @meteorcloudy, is there a way to fix the regression on top of bazel 0.18.0, or do we have to wait for 0.19.0 with the fix?

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

meteorcloudy · 2018-10-24T14:41:01Z

I think the non-JDK issue is already fixed in 0.19.0 or at least from HEAD.
See this issue #6214

meteorcloudy · 2018-10-24T15:10:33Z

Due to some CI change, we cannot test 0.18.0rc3 on our CI. But I ran a test on my local Windows machine that confirmed the manually cherry-pick did fix #6292.

petemounce · 2018-10-25T06:48:23Z

0.18.1 rc3 pushed to chocolatey. Please could a new release issue be opened for new releases? It's quite easy to miss, otherwise; this ticket is closed.

ittaiz · 2018-10-26T16:10:21Z

Can you please cherry pick e025726 for #6456? Thanks! Cc @cushon

aehlig · 2018-10-29T09:51:58Z

On Fri, Oct 26, 2018 at 04:10:42PM +0000, Ittai Zeidman wrote: Can you please cherry pick e025726 for #6456? Thanks! Cc @cushon

scripts/release/release.sh create --force_rc=4 0.18.1 c062b1f 2834613 2579b79 faaff7f b073a18 bf6a63d c1a7b4c 71926bc 86a8217 914b4ce e025726

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

ittaiz · 2018-10-29T21:16:21Z

Thanks!

…

On Mon, 29 Oct 2018 at 11:52 Klaus Aehlig ***@***.***> wrote: On Fri, Oct 26, 2018 at 04:10:42PM +0000, Ittai Zeidman wrote: > Can you please cherry pick e025726 for #6456? Thanks! Cc @cushon scripts/release/release.sh create --force_rc=4 0.18.1 c062b1f 2834613 2579b79 faaff7f b073a18 bf6a63d c1a7b4c 71926bc 86a8217 914b4ce e025726 -- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen <https://maps.google.com/?q=Erika-Mann-Str.+33,+80636+Muenchen&entry=gmail&source=g> Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5963 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF_g0bV8EbCxBk_V-At2gy_g9E1AHks5ups_WgaJpZM4WIVco> .

petemounce · 2018-10-29T21:32:10Z

0.18.1-rc4 is published to chocolatey.

aehlig · 2018-10-31T15:06:39Z

0.18.1 is available at https://github.com/bazelbuild/bazel/releases/tag/0.18.1

…

-- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado

petemounce · 2018-11-01T09:03:02Z

0.18.1 is pushed to chocolatey

ahippler · 2018-11-01T11:46:00Z

bazel-0.18.1-installer-darwin-x86_64.sh is missing while the sha and the signature are available.

laurentlb added the release label Aug 22, 2018

laurentlb assigned aehlig Aug 22, 2018

gregmagolan mentioned this issue Sep 7, 2018

Fine-grained npm_install & yarn_install deps bazelbuild/rules_nodejs#302

Merged

laurentlb mentioned this issue Sep 10, 2018

0.16.1 javac cannot find nashorn symbols #6060

Closed

cushon mentioned this issue Sep 10, 2018

never use @embedded_jdk for --javabase #6105

Closed

aehlig mentioned this issue Sep 11, 2018

Gerrit failing with Bazel@HEAD #6127

Closed

aehlig closed this as completed Oct 15, 2018

aehlig mentioned this issue Oct 25, 2018

[Regression 0.17.2 -> 0.18] Turbine failure #6456

Closed

jin mentioned this issue Nov 5, 2018

sha256 value mismatch for bazel-0.18.1-installer-darwin-x86_64.sh #6598

Closed

Release - September 2018 - name: 0.18.0 #5963

Release - September 2018 - name: 0.18.0 #5963

Comments

laurentlb commented Aug 22, 2018

aehlig commented Aug 23, 2018 via email

laurentlb commented Aug 23, 2018

hlopko commented Sep 3, 2018

laszlocsomor commented Sep 3, 2018 • edited Loading

aehlig commented Sep 10, 2018 via email

laszlocsomor commented Sep 10, 2018 • edited Loading

laszlocsomor commented Sep 10, 2018

aehlig commented Sep 10, 2018 via email

laurentlb commented Sep 10, 2018

hlopko commented Sep 10, 2018

aehlig commented Sep 10, 2018 via email

aehlig commented Sep 10, 2018 via email

lberki commented Sep 10, 2018

cushon commented Sep 10, 2018

cushon commented Sep 10, 2018

lberki commented Sep 11, 2018

aehlig commented Sep 11, 2018

hlopko commented Sep 11, 2018

davido commented Sep 11, 2018 • edited Loading

aehlig commented Sep 11, 2018 via email

aehlig commented Sep 11, 2018

davido commented Sep 11, 2018

aehlig commented Sep 11, 2018

lberki commented Sep 11, 2018 • edited Loading

dslomov commented Oct 5, 2018 • edited Loading

petemounce commented Oct 8, 2018

sdqali commented Oct 10, 2018

aehlig commented Oct 10, 2018 via email

hlopko commented Oct 15, 2018

laurentlb commented Oct 15, 2018 • edited Loading

hlopko commented Oct 15, 2018

aehlig commented Oct 15, 2018

aehlig commented Oct 15, 2018

petemounce commented Oct 15, 2018

laurentlb commented Oct 16, 2018

meteorcloudy commented Oct 17, 2018

aehlig commented Oct 22, 2018 via email

meteorcloudy commented Oct 23, 2018

aehlig commented Oct 23, 2018 via email

aehlig commented Oct 24, 2018 via email

aehlig commented Oct 24, 2018 via email

meteorcloudy commented Oct 24, 2018

meteorcloudy commented Oct 24, 2018

petemounce commented Oct 25, 2018

ittaiz commented Oct 26, 2018

aehlig commented Oct 29, 2018 via email

ittaiz commented Oct 29, 2018 via email

petemounce commented Oct 29, 2018

aehlig commented Oct 31, 2018 via email

petemounce commented Nov 1, 2018

ahippler commented Nov 1, 2018

laszlocsomor commented Sep 3, 2018 •

edited

Loading

laszlocsomor commented Sep 10, 2018 •

edited

Loading

davido commented Sep 11, 2018 •

edited

Loading

lberki commented Sep 11, 2018 •

edited

Loading

dslomov commented Oct 5, 2018 •

edited

Loading

laurentlb commented Oct 15, 2018 •

edited

Loading