Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zip64 in //third_party/ijar:zip #6211

Closed
meteorcloudy opened this issue Sep 24, 2018 · 9 comments
Closed

Support zip64 in //third_party/ijar:zip #6211

meteorcloudy opened this issue Sep 24, 2018 · 9 comments
Assignees
@alexjski
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@meteorcloudy
Copy link
Member

A tensorflow issue (tensorflow/tensorflow#22390) revealed bazel's zip tool //third_party/ijar:zip doesn't support compressing file that's larger than 4GB.

https://github.com/bazelbuild/bazel/blob/0.17.1/third_party/ijar/zip.cc#L74

/cc @cushon
@meteorcloudy meteorcloudy added type: feature request P2 We'll consider working on this in future. (Assignee optional) labels Sep 24, 2018
@meteorcloudy meteorcloudy mentioned this issue Sep 24, 2018
Closed
@cushon
Copy link
Contributor

cushon commented Sep 24, 2018

//third_party/ijar:zip is one of Bazel's zip implementations, but I'm surprised it's being used for this. It looks like this is related to https://bazel-review.googlesource.com/c/bazel/+/4244.

Did you consider using singlejar instead?

@meteorcloudy
Copy link
Member Author

Yes, I added python zip support using //third_party/ijar:zip, because at that time the C++ implementation of singlejar didn't work on Windows.
An external contributor has been working on #2241, I'll try to replace zip with singlejar here after it's done.
Thanks for the help!

@meteorcloudy meteorcloudy self-assigned this Sep 25, 2018
@meteorcloudy meteorcloudy mentioned this issue Sep 25, 2018
Closed
@gunan
Copy link

gunan commented Mar 11, 2020

Any updates here?
TF is hitting this again.

@meteorcloudy
Copy link
Member Author

@gunan I don't think there is any progress or planned work on this. I thought we have the workaround for TF by excluding deps for py_binary. That doesn't work anymore?

@gunan
Copy link

gunan commented Mar 12, 2020

Unfortunately, our library's growth has made the workaround not work for us reliably any more.
How difficult do you this is this task? With guidance, do you think someone from our end could od it?

@meteorcloudy
Copy link
Member Author

I guess if someone familiar with how zip works can try, I'm not sure how much guidance the Bazel team can provide.

@jin jin added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Mar 2, 2021
bazel-io pushed a commit that referenced this issue Mar 25, 2021
@alexjski
Add support for unzipping ZIP64(tm) archives in ijar.
3354ce3 
Add support for unzipping archives which exceed 4GB in size. Add `ZIP64(tm)`
extensions handling to get proper compressed/uncompressed sizes and offsets
within the zip file.

Related to #6211.

PiperOrigin-RevId: 365047127
@fkorotkov fkorotkov mentioned this issue Apr 5, 2022
Closed
@oxidase oxidase mentioned this issue Apr 2, 2023
Open
@github-actions
Copy link

github-actions bot commented May 9, 2023

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 9, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@AustinSchuhBRT
Copy link

I just ran into this bug, seems like it is still relevant. @bazelbuild/triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjski alexjski

Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jin @cushon @meteorcloudy @gunan @alexjski @AustinSchuhBRT