Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate extra values for srcs_version. #6445

Closed
brandjon opened this issue Oct 18, 2018 · 4 comments
Closed

Deprecate extra values for srcs_version. #6445

brandjon opened this issue Oct 18, 2018 · 4 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

Current allowed srcs_version values are:

  • PY2ONLY: errors out if built in PY3 mode
  • PY2: originally intended to mean "do 2to3 conversion", but it errors out (badly) if built in PY3 mode
  • PY2AND3: works for both PY2 and PY3 (no 2to3 conversion)
  • PY3ONLY: errors out if built in PY2 mode
  • PY3: same as PY3ONLY

We should reduce this to something like just:

  • PY2 (behaving like PY2ONLY does today)
  • PY2AND3
  • PY3
@brandjon brandjon added P2 We'll consider working on this in future. (Assignee optional) type: process team-Rules-Python Native rules for Python labels Oct 18, 2018
@brandjon brandjon self-assigned this Oct 18, 2018
@brandjon
Copy link
Member Author

Accompanying the fix for this and #1393, we'll also make the error message less confusing for when you have the wrong major python version.

@brandjon
Copy link
Member Author

brandjon commented Nov 5, 2018

One question raised by these names is: What happens when there is a Python 4? At present it looks like while there are some references in PEPs and mailing lists to "Python 4", that's used as a stand-in to mean "a breaking change release". Alternative interpretations are that Python 4 will just be Python 3.10. Either way, until more concrete plans emerge from the Python developers, no sense speculating in our plans here. Python 2 compatibility features may very well be deprecated by the time it becomes a concern.

@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 18, 2020
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 12, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process
Projects
None yet
Development

No branches or pull requests

2 participants