Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking bug for python 2/3 mode issues #6444

Closed
6 of 13 tasks
brandjon opened this issue Oct 18, 2018 · 8 comments
Closed
6 of 13 tasks

Tracking bug for python 2/3 mode issues #6444

brandjon opened this issue Oct 18, 2018 · 8 comments
Assignees
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: bug

Comments

@brandjon
Copy link
Member

brandjon commented Oct 18, 2018

This bug is to index issues related to selecting Python 2 vs Python 3 mode for py_* targets. The goal is to have sane semantics for this mode selection implemented and documented by EoQ4.

See also Andreas's index of Python 3 issues at #1580. That index is broader-scoped; here I'm mainly concerned with inconsistencies and limitations in --force_python and its related attributes default_python_version and srcs_version.

Note that many of these issues are addressed by common work to redesign the Python mode state. This work is tracked by #6583.

We should also have per-target ability to control the python runtime, but that's part of a separate improvement to have a "py_toolchain" style rule. In the meantime you can use select() on the force_python flag within a py_runtime rule to get different runtimes for PY2 vs PY3 targets. See for instance here.

@brandjon brandjon added type: bug P2 We'll consider working on this in future. (Assignee optional) category: rules > python labels Oct 18, 2018
@brandjon brandjon self-assigned this Oct 18, 2018
@brandjon brandjon added team-Rules-Python Native rules for Python and removed category: rules > python labels Oct 18, 2018
umairidris pushed a commit to GoogleCloudPlatform/healthcare that referenced this issue Nov 29, 2018
Continue supporting py2 till bazelbuild/bazel#6444 is solved.

PiperOrigin-RevId: 223026635
@cclauss
Copy link

cclauss commented Nov 12, 2019

What is status on this one? P3 We're not considering working on this, but happy to review a PR. (No assignee)

@lberki
Copy link
Contributor

lberki commented Nov 18, 2020

@brandjon , I suppose we should just close this since Python 2 support is almost deprecated?

@brandjon
Copy link
Member Author

Downgrading to P4 to get off my issue tracker since I'm no longer maintaining Python rules. CCing @rickeylev as current label owner.

No idea what our stance is on Python 2 support in Bazel, three years out from its deprecation in the wild. That's probably a product management question that goes beyond mere Python rule TLs.

@brandjon brandjon added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 19, 2022
@cclauss
Copy link

cclauss commented Dec 19, 2022

Python 2 died 1,083 days ago on 1/1/2020. It is history.

@brandjon
Copy link
Member Author

The question is whether all users of Bazel are free from history. Then again, we have LTS now, so I'm sure the need to keep it at head is greatly diminished.

Still, product management, so I won't weigh in. :)

@rickeylev
Copy link
Contributor

As another data point over in rules_python, as of bazelbuild/rules_python#887 (Dec 1, 2022), we started rejecting PY2 values for python_version and srcs_version at the start of and haven't heard any complaints.

Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 10, 2024
Copy link

github-actions bot commented Jun 8, 2024

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: bug
Projects
None yet
Development

No branches or pull requests

4 participants