Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support android_instrumentation_test on macOS #7069

Closed
jin opened this issue Jan 9, 2019 · 7 comments
Closed

Support android_instrumentation_test on macOS #7069

jin opened this issue Jan 9, 2019 · 7 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Android Issues for Android team type: feature request

Comments

@jin
Copy link
Member

jin commented Jan 9, 2019

Tracking issue for android_instrumentation_test support on macOS.
@jin jin added type: feature request P1 I'll work on this now. (Assignee required) team-Android Issues for Android team labels Jan 9, 2019
@jin jin self-assigned this Jan 9, 2019
@jin
Copy link
Member Author

jin commented Feb 16, 2019

This is blocked on the availability of Project Nitrogen publicly.

@jin
Copy link
Member Author

jin commented Mar 21, 2019

While integration with Nitrogen is WIP, I've made a experimental rule that uses the Composer test runner, and it works on a Mac: https://github.com/jin/rules_experimental_android#composer-integration

@jin jin assigned jin and unassigned jin Jun 22, 2019
@jin jin mentioned this issue Oct 1, 2019
Closed
@jin jin added P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels Apr 28, 2020
@jin jin removed their assignment Apr 28, 2020
@jinchizhou
Copy link

Is android_instrumentation_test still not supported on macOS? I'm still getting #9452.

@nkoroste
Copy link
Contributor

nkoroste commented Jul 7, 2020

@jin why is this not higher priority? I think being able to run tests on a Mac is a pretty big deal

@jin
Copy link
Member Author

jin commented Jul 8, 2020

It's been a while since this was being worked on (I no longer work on Android rules). AFAIK, we were waiting for the multiplatform Nitrogen test runner (as I commented above), instead of making the legacy test infrastructure work on more platforms.

keith added a commit to keith/bazel that referenced this issue Mar 21, 2022
@keith
Fix android emulator darwin_arm64 select
9bc4f3b 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
bazelbuild#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs
@keith keith mentioned this issue Mar 21, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 27, 2022
@keith
Fix android emulator darwin_arm64 select
73f1ecb 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275
@ckolli5 ckolli5 mentioned this issue May 10, 2022
Merged
ckolli5 added a commit that referenced this issue May 10, 2022
@ckolli5 @keith
Fix android emulator darwin_arm64 select (#15445)
c8b6496 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
meteorcloudy pushed a commit that referenced this issue May 10, 2022
@ckolli5 @keith @meteorcloudy
Fix android emulator darwin_arm64 select (#15445)
e1ea2a9 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
@Augustyniak Augustyniak mentioned this issue Aug 2, 2022
Open
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2.5 years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 16, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Android Issues for Android team type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jin @nkoroste @jinchizhou