Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad error messaging when using the deprecated PACKAGE_NAME or REPOSITORY_NAME #7331

Closed
Reflexe opened this issue Feb 2, 2019 · 3 comments
Closed

bad error messaging when using the deprecated PACKAGE_NAME or REPOSITORY_NAME #7331

Reflexe opened this issue Feb 2, 2019 · 3 comments
Assignees
@laurentlb
Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong P1 I'll work on this now. (Assignee required)

Comments

@Reflexe
Copy link
Contributor

Reflexe commented Feb 2, 2019

Description of the problem / feature request:

Instead of a nice deprecation warning / error, I got this ambiguous error: builtin variable 'REPOSITORY_NAME' is referenced before assignment..

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Use REPOSITORY_NAME or PACKAGE_NAME. With master too.

What operating system are you running Bazel on?

Linux

What's the output of bazel info release?

release 0.22.0- (@non-git)

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

Official archlinux release

Have you found anything relevant by searching the web?

This deprecation thread
@Reflexe Reflexe changed the title very bad error when using the deprecated PACKAGE_NAME or REPOSITORY_NAME bad error messaging on using the deprecated PACKAGE_NAME or REPOSITORY_NAME Feb 2, 2019
@aiuto aiuto added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Feb 4, 2019
@Reflexe
Copy link
Contributor Author

Reflexe commented Feb 4, 2019 •
edited
Loading

Not team-Starlark?
I'm tagging @c-parsons since {s,}he has opened the original deprecation issue.

@Reflexe Reflexe changed the title bad error messaging on using the deprecated PACKAGE_NAME or REPOSITORY_NAME bad error messaging when using the deprecated PACKAGE_NAME or REPOSITORY_NAME Feb 4, 2019
@laurentlb laurentlb added P1 I'll work on this now. (Assignee required) team-Starlark bad error messaging Issues where users get stuck because they don't understand what they did wrong and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Feb 18, 2019
@laurentlb laurentlb self-assigned this Feb 18, 2019
@laurentlb
Copy link
Contributor

It's probably my fault, sorry about that.
I'm looking at it.

@Reflexe
Copy link
Contributor Author

Reflexe commented Feb 19, 2019

@laurentlb I guess you did too much refactoring on 2b3ad18 and removed the warning with the flag by mistake.

This was referenced Feb 21, 2019
Closed
Closed
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Restore deprecation error for {PACKAGE,REPOSITORY}_NAME
30ec759 
    This code has been removed by mistake in
    2b3ad18eec4e6b968d840777249c809e478b2e13.
    This commit also restores its test.

    Fixes bazelbuild/bazel#7331

    Closes #7491.

    PiperOrigin-RevId: 235037738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentlb laurentlb

Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong P1 I'll work on this now. (Assignee required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurentlb @aiuto @Reflexe