Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"allow analysis failures" mode does not work with SkylarkErrorReporter #8234

Closed
c-parsons opened this issue May 3, 2019 · 0 comments
Closed

"allow analysis failures" mode does not work with SkylarkErrorReporter #8234

c-parsons opened this issue May 3, 2019 · 0 comments
Assignees
@c-parsons
Labels
P1 I'll work on this now. (Assignee required) type: bug

Comments

@c-parsons
Copy link
Contributor

c-parsons commented May 3, 2019 •
edited

The effect of this bug is that bazel-skylib's analysistest framework doesn't quite work as intended (rule errors should be suppressed and reported differently under "expect failures" mode of that framework, but it is not always so, when SkylarkErrorReporter is used.

SkylarkErrorReporter should reflect the "allow analysis failures" mode of the configuration.
@c-parsons c-parsons added type: bug P1 I'll work on this now. (Assignee required) team-Starlark labels May 3, 2019
@c-parsons c-parsons self-assigned this May 3, 2019
bazel-io pushed a commit that referenced this issue Jun 21, 2019
@c-parsons
Change ruleContext.hasError() to reflect even suppressed errors
146b9ff 
This makes error-checking logic more consistent, even under --allow_analysis_failures. This also requires some changes to target factories to ensure they are aware of allow_analysis_failures mode, and will propagate non-null error-messaging targets in cases of this mode.

Fixes #8234

RELNOTES: None.
PiperOrigin-RevId: 254413823
siberex pushed a commit to siberex/bazel that referenced this issue Jul 4, 2019
@c-parsons @siberex
Change ruleContext.hasError() to reflect even suppressed errors
68f66a1 
This makes error-checking logic more consistent, even under --allow_analysis_failures. This also requires some changes to target factories to ensure they are aware of allow_analysis_failures mode, and will propagate non-null error-messaging targets in cases of this mode.

Fixes bazelbuild#8234

RELNOTES: None.
PiperOrigin-RevId: 254413823
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@c-parsons @irengrig
Change ruleContext.hasError() to reflect even suppressed errors
02aad08 
This makes error-checking logic more consistent, even under --allow_analysis_failures. This also requires some changes to target factories to ensure they are aware of allow_analysis_failures mode, and will propagate non-null error-messaging targets in cases of this mode.

Fixes bazelbuild#8234

RELNOTES: None.
PiperOrigin-RevId: 254413823
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Change ruleContext.hasError() to reflect even suppressed errors
b6bab46 
    This makes error-checking logic more consistent, even under --allow_analysis_failures. This also requires some changes to target factories to ensure they are aware of allow_analysis_failures mode, and will propagate non-null error-messaging targets in cases of this mode.

    Fixes bazelbuild/bazel#8234

    RELNOTES: None.
    PiperOrigin-RevId: 254413823
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Make SkylarkErrorReporter proxy ruleContext error consumer
215e3f2 
    Fixes bazelbuild/bazel#8234

    RELNOTES: None.
    PiperOrigin-RevId: 246571018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-parsons c-parsons

Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c-parsons