Wrong assembler flags in Windows toolchain

[excitoon]

Please kindly look at a reproduction case here: https://github.com/excitoon/bazel-issues/tree/master/windows-assembler

C:\Users\Chebotarev_V\Documents\src\bazel-issues\windows-assembler>bazelisk build ...
Starting local Bazel server and connecting to it...
INFO: Analyzed target //:test (13 packages loaded, 71 targets configured).
INFO: Found 1 target...
INFO: From Compiling 1.asm:
MASM : warning A4018:invalid command-line option : /bigobj
MASM : warning A4018:invalid command-line option : /Zm500
MASM : warning A4018:invalid command-line option : /Z500
MASM : warning A4018:invalid command-line option : /Z00
MASM : warning A4018:invalid command-line option : /Z0
MASM : warning A4018:invalid command-line option : /EHsc
MASM : warning A4018:invalid command-line option : /wd4351
MASM : warning A4018:invalid command-line option : /wd4291
MASM : warning A4018:invalid command-line option : /wd4250
MASM : warning A4018:invalid command-line option : /wd4996
 Assembling: 1.asm
Target //:test up-to-date:
  bazel-bin/test.exe
INFO: Elapsed time: 14.480s, Critical Path: 0.41s
INFO: 3 processes: 3 local.
INFO: Build completed successfully, 7 total actions

Version

C:\Users\Chebotarev_V\Documents\src\bazel-issues\windows-assembler>bazelisk version
Build label: 0.28.0
Build target: bazel-out/x64_windows-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed Jul 10 16:15:38 2019 (1562775338)
Build timestamp: 1562775338
Build timestamp as int: 1562775338

[laszlocsomor]

Thanks for reporting.
To be clear, the problem is passing the cl.exe flags to ml64.exe?

[laszlocsomor]

@scentini : I need your help triaging this please :)

[scentini]

From a brief look, seems like we shouldn't add these flags to the assemble actions here.

I will take a look early next month to see if removing those actions from the default_compile_flags feature is enough.

[excitoon]

@laszlocsomor exactly.

[sgowroji]

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

[excitoon]

Reproduce it by yourself

…

On Wed, Feb 15, 2023, 10:28 AM Gowroji Sunil ***@***.***> wrote: Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so. — Reply to this email directly, view it on GitHub <#8924 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARGSBYHIE5RRRKU4OMVVHTWXSARPANCNFSM4IEZPP7A> . You are receiving this because you authored the thread.Message ID: ***@***.***>