Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom build flags choke on prefix workspaces #9177

Open
ulysses4ever opened this issue Aug 15, 2019 · 6 comments

Comments

@ulysses4ever
Copy link
Contributor

commented Aug 15, 2019

Description of the problem

I believe custom build flags don't play well with proper @namespace//...-like references.

Bugs: what's the simplest, easiest way to reproduce this bug?

I set up a repository with a repro -- check out the README. It follows closely the running example of drinks and flavors in the documentation. Except that it actually sets up a named workspace.

In the master branch of the repo, everything is fine: I'm able to pass the flag in the command line. In the bug branch I add the workspace prefix when referencing the flag target from the attribute of my rule. This breaks the setup: I pass the flag in the command-line as before but it has no effect. If I try to add the workspace prefix when referencing the flag from the command-line, I get "Unrecognized option".

What operating system are you running Bazel on?

Ubuntu 18.04

What's the output of bazel info release?

release 0.28.0- (@non-git)

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

This is the version of Bazel imported by Nixpkgs version referenced in the current rules_haskell (master branch).

Have you found anything relevant by searching the web?

No. I only looked up the Issues here.

@ulysses4ever

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

May I ping @juliexxia who did most of the job of implementing this exciting feature! And also @c-parsons who merged it.

@aiuto

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Thanks for the detailed example.
@juliexxia is away on a fellowship for a few months. We'll get the right people to look at it.

@katre katre added P2 type: bug and removed untriaged labels Aug 27, 2019
@gregestren gregestren removed their assignment Sep 11, 2019
@gregestren

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

This is a cutting edge feature so I'm not surprised this part doesn't work yet. I don't think anyone can take this on right now, but please re-ping whenever you feel to help us figure out a practical fix timeline.

Appreciate your patient guinea pigging!

@ulysses4ever

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@gregestren thanks for letting me know. I didn't quite get when you want me to re-ping you.

@gregestren

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

There's no obvious person to work on this right now (#9177 (comment)). I don't want this to fall into oblivion but it might get lost in the issue load. So please offer us some leeway but feel free to re-ping if/when you feel it's sitting around for too long. :)

@ulysses4ever

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

I see, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.