Catch SocketException instead of BindException to handle disabled IPv6 #11400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
StarlarkDebugServerTest
andDebugServerTransportTest
fails with errorjava.net.SocketException: Protocol family unavailable
in some enviroments.Explanation:
If IPv6 is disabled in docker container ServerSocket fails to bind to ::1 with
java.net.SocketException
.But bazel tests falls back to IPv4 only if
java.net.BindException
(subclass ofjava.net.SocketException
) occurs.Let's catch more generic
java.net.SocketException