Fix export of @bazel_tools//src/main/protobuf #11611
Conversation
`src/main/protobuf/BUILD` referenced other parts of the Bazel source tree which aren't available when repackaged into the embedded tools distribution. This commit adds a parallel `BUILD.tools` which is stripped of any such references. Resolves #8738. Testing Done: - Referred to `@bazel_tools//src/main/protobuf:worker_protocol.proto` in an internal rule w/o encountering #8738.
|
Not sure what the scope of any test case(s) should be. My best guess would be something similar to |
|
I assigned reviewers based on who had the TODO and who the blame layer points to. |
Replace local copy of `worker_protocol.proto` with `@bazel_tools//src/main/protobuf:worker_protocol_java_proto` Local copy requires keeping track of changes in worker protocol (though it should be pretty stable). To be honest I'm not sure `@bazel_tools//src/main/protobuf:worker_protocol_java_proto` is part of public interface (see bazelbuild/bazel#11611).
|
@meisterT Friendly ping :P |
|
@beasleyr-vmw Could you just copy that protocol buffer file to your repository instead? Protobufs are supposed to be backwards compatible, so even if you don't update your version for some time, it should be fine until you want to use newer fields. It's also easier for tools like Code Search (if you use that) if the protobuf is in the repo, instead of an embedded repo inside the Bazel binary. I tried to import it, but I'm not sure if the overhead of maintaining yet another parallel BUILD file that might get out of date in our code is worth it. |
|
@philwo If that's the official position, I'm fine with it. I'm unfamiliar w/ protobuf best practices, but my gut feeling was to stick to canonical locations instead of privately snapshotting the .proto files. LMK and I can withdraw this. |
|
@beasleyr-vmw thanks for your understanding - I agree with Philipp that the separate BUILD file is brittle (it's untested) and overhead. |
ghost
deleted the
src/main/protobuf/BUILDreferenced other parts of the Bazel source treewhich aren't available when repackaged into the embedded tools distribution.
This commit adds a parallel
BUILD.toolswhich is stripped of any suchreferences.
Resolves #8738.
Testing Done:
@bazel_tools//src/main/protobuf:worker_protocol.protoinan internal rule w/o encountering Unable to reference @bazel_tools//src/main/protobuf targets #8738.