Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark: test loaded symbols are not reexported #12726

Closed
wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

Test this logic:

a.bzl:
x = 1

b.bzl:
load("a.bzl", "x")

c.bzl:
load("b.bzl", "x")  # Should fail here

I have not found tests for this, so add test to EvaluationTest.

Test this logic:

```
a.bzl:
x = 1

b.bzl:
load("a.bzl", "x")

c.bzl:
load("b.bzl", "x")  # Should fail here
```

I have not found tests for this, so add test to `EvaluationTest`.
Copy link
Contributor

@alandonovan alandonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice test.

@bazel-io bazel-io closed this in c2f2e36 Feb 8, 2021
@stepancheg stepancheg deleted the load-reexport branch February 8, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants