Revert "Switch to -fdebug-compilation-dir" #12882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cb8757. This flag isn't supported by Xcode 11.2, which is the newest available version for macOS 10.14 bazelbuild#12354 (comment)
This was referenced Jan 25, 2021
|
@oquenchil can you review? |
This was referenced Jan 26, 2021
|
@keith The crosstool has an Xcode versions compare helper that maybe we can use to conditionally add this flag. bazel/tools/osx/crosstool/cc_toolchain_config.bzl Lines 36 to 38 in 0cb8757 |
|
Yea, idk if it's worth it unless this flag provides more benefit. I was just trying to simplify the wrapper's replacements thinking it was fine with our minimum supported versions. |
This was referenced Feb 4, 2021
arunkumar9t2
pushed a commit
to arunkumar9t2/bazel
that referenced
this pull request
Feb 9, 2021
This reverts commit 0cb8757. This flag isn't supported by Xcode 11.2, which is the newest available version for macOS 10.14 bazelbuild#12354 (comment) Fixes bazelbuild#12905 Closes bazelbuild#12882. PiperOrigin-RevId: 355126529
|
👋 do we have a plan about when releasing this change? Thanks! |
|
best to comment on #12455 |
|
FYI to workaround this now you can pass |
5 tasks
thundergolfer
pushed a commit
to thundergolfer/uni
that referenced
this pull request
Feb 21, 2021
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
This reverts commit 0cb8757. This flag isn't supported by Xcode 11.2, which is the newest available version for macOS 10.14 #12354 (comment) Fixes #12905 Closes #12882. PiperOrigin-RevId: 355126529
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
This reverts commit 0cb8757. This flag isn't supported by Xcode 11.2, which is the newest available version for macOS 10.14 #12354 (comment) Fixes #12905 Closes #12882. PiperOrigin-RevId: 355126529
pipecd-bot
pushed a commit
to pipe-cd/pipecd
that referenced
this pull request
May 28, 2021
**What this PR does / why we need it**: [v4.1.0](https://github.com/bazelbuild/bazel/releases/tag/4.1.0) got released last week. This release includes bazelbuild/bazel#12882, which fixes what we were facing; no longer needed to come with the workaround. I've confirmed that it works fine without passing the workaround flag `--features=-debug_prefix_map_pwd_is_dot`. **Which issue(s) this PR fixes**: Fixes #1913 **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0cb8757.
This flag isn't supported by Xcode 11.2, which is the newest available
version for macOS 10.14
#12354 (comment)
Fixes #12905