Shade com.google.common.** in the Jacoco test runner. #12999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isolates the Bazel coverage runner's version of Guava from the user's. Testing Done: - Verified `bazel coverage` worked against a crufty internal target using this patch with java_tools javac11-10.5 and Bazel 4.0.0. - `bazelisk build src:java_tools.zip`; manual inspection of `JacocoCoverage_jarjar_deploy.jar`.
|
cc @comius Apologies for delay. We had a long holiday weekend. |
comius
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isolates the Bazel coverage runner's version of Guava from the
user's.
Resolves #12998
Testing Done:
bazel coverageworked against a crufty internal targetusing this patch with java_tools javac11-10.5 and Bazel 4.0.0.
bazelisk build src:java_tools.zip; manual inspection ofJacocoCoverage_jarjar_deploy.jar.