Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be less aggressive in interpreting flags as response files #13044

Closed
wants to merge 1 commit into from
Closed

Be less aggressive in interpreting flags as response files #13044

wants to merge 1 commit into from

Commits on Feb 15, 2021

  1. Be less aggressive in interpreting flags as response files 

    Both -Xlinker and -install_name will often receive flags starting with
`@`, specifically `@loader_path` or `@rpath`. Bazel 4.0 started
interpreting those as response files which broke our build.

This PR addresses this by hardcoding those flags. This is a pretty
ugly solution so I’m very open to better ideas. That said, there is
some precedence for doing that in
[rules-haskell](https://github.com/tweag/rules_haskell/blob/e8623a8c5ea502fbe6286d8ae5fb58f4915e92c5/haskell/private/cc_wrapper.py.tpl#L448).
    @cocreature
    cocreature committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    f665e7b View commit details
    Browse the repository at this point in the history