And mnemonic and label to remote metadata #13109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
added
the
team-Remote-Exec
|
Thanks for the PR! For reasons, we cannot merge a PR containing both third_party and non-third_party changes. Can you please split this into two PRs? (One for updating REAPI and another one for adding additional metadata) |
|
I split off #13133 for just the proto change, now that it's merged upstream :) Thanks! |
illicitonion
force-pushed
the
per-action-metadata
branch
from
4e5dcaf
to
0e05f38
Compare
illicitonion
force-pushed
the
per-action-metadata
branch
from
0e05f38
to
6204027
Compare
|
Rebased :) Thanks! |
ulfjack
added a commit
to EngFlow/bazel
that referenced
this pull request
Mar 5, 2021
This is a partial application of a pending pull request against Bazel HEAD: bazelbuild#13109 Unfortunately, the PR does not apply to Bazel 3.7 at all due to extensive changes in how metadata is propagated through the remote execution stack. Change-Id: I99e98f32fd460df03fb57838e2a7327646a22940
ulfjack
added a commit
to EngFlow/bazel
that referenced
this pull request
Mar 5, 2021
This is a partial application of a pending pull request against Bazel HEAD: bazelbuild#13109 Unfortunately, the PR does not apply to Bazel 3.7 at all due to extensive changes in how metadata is propagated through the remote execution stack. Change-Id: I99e98f32fd460df03fb57838e2a7327646a22940
|
Waiting for bazelbuild/remote-apis#186 to be imported. Once that's done, this should be merged automatically. |
|
@coeuvre It seems like the linked change was already merged:
Is there something left to do? |
|
Yes. We use internal version of REAPI internally. The linked change need to be imported to the internal REAPI first so we can import this change. (b/182107620) |
illicitonion
force-pushed
the
per-action-metadata
branch
from
6204027
to
1cd80cf
Compare
illicitonion
force-pushed
the
per-action-metadata
branch
from
1cd80cf
to
642a906
Compare
|
(Friendly ping :-) ) |
philwo
pushed a commit
that referenced
this pull request
Apr 20, 2021
This reflects bazelbuild/remote-apis#186 Closes #13109. PiperOrigin-RevId: 368763391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects bazelbuild/remote-apis#186