Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osx_cc_wrapper: Only expand existing response files #13148

Closed
wants to merge 2 commits into from
Closed

osx_cc_wrapper: Only expand existing response files #13148

wants to merge 2 commits into from

Commits on Mar 3, 2021

  1. osx_cc_wrapper: Only expand existing response files 

    Not all arguments starting with `@` represent response files, e.g.
`-install_name @rpath/...` or
`-Xlinker -rpath -Xlinker @loader_path/...`.

With this change `osx_cc_wrapper` will only interpret arguments starting
with `@` as response files if the corresponding file exists and is
readable. This is analogous to the behavior defined in
`wrapped_clang.cc`.
See bazelbuild#13044 (comment)
for discussion.
    @aherrmann
    aherrmann committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    fc24e1c View commit details
    Browse the repository at this point in the history

  2. Update tools/cpp/osx_cc_wrapper.sh 

    Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
    @aherrmann @keith
    aherrmann and keith committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    7acc8f3 View commit details
    Browse the repository at this point in the history