Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the logic to read user netrc file #14588

Closed
wants to merge 5 commits into from
Closed

Expose the logic to read user netrc file #14588

wants to merge 5 commits into from

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jan 17, 2022 •
edited
Loading

Repository rules that download repositories from internal website often need to read users .netrc files. This PR exposes the logic for other repository rules to use.

@linzhp linzhp marked this pull request as draft January 17, 2022 16:09
@linzhp linzhp changed the title Expose get_auth for other repository rules to use Expose the logic to read user netrc file Jan 18, 2022
@linzhp linzhp marked this pull request as ready for review January 18, 2022 04:41
@bazel-io bazel-io closed this in f421474 Jan 21, 2022
@linzhp linzhp deleted the get_auth branch January 25, 2022 18:11
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Mar 7, 2022
@linzhp @brentleyjones
Expose the logic to read user netrc file
b315086 
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use.

Closes bazelbuild#14588.

PiperOrigin-RevId: 423291624
(cherry picked from commit f421474)
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Mar 7, 2022
@linzhp @brentleyjones
Expose the logic to read user netrc file
7148ef2 
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use.

Closes bazelbuild#14588.

PiperOrigin-RevId: 423291624
(cherry picked from commit f421474)
Wyverald pushed a commit that referenced this pull request Mar 7, 2022
@brentleyjones @linzhp
Expose the logic to read user netrc file (#14990)
87ef5ce 
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use.

Closes #14588.

PiperOrigin-RevId: 423291624
(cherry picked from commit f421474)

Co-authored-by: Zhongpeng Lin <zplin@uber.com>
@linzhp linzhp mentioned this pull request Sep 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald left review comments

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linzhp @Wyverald @meteorcloudy