Collect implementation_deps in graph node aspect #14730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
cc-shared-library-implementation-deps
branch
from
1809779
to
bd6b959
Compare
This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets.
fmeum
force-pushed
the
cc-shared-library-implementation-deps
branch
from
ae000fc
to
630a4a0
Compare
|
@oquenchil I noticed that the starlark implementation has already been fixed. This PR still adds a test and a fix for the Java implementation. Is that useful? |
oquenchil
approved these changes
Sep 16, 2022
oquenchil
added
the
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
*** Reason for rollback *** Due to #16296 (comment) *** Original change description *** Collect implementation_deps in graph node aspect This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets. Fixes #14731 Closes #14730. PiperOrigin-RevId: 480360695 Change-Id: Ic1b9c17ce3af730fa0131f5d87e5ca99ae2740c5
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets. Fixes bazelbuild#14731 Closes bazelbuild#14730. PiperOrigin-RevId: 479253298 Change-Id: I933f2e9fc3171378cc95a50c59a426489b8724c3
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
*** Reason for rollback *** Due to bazelbuild#16296 (comment) *** Original change description *** Collect implementation_deps in graph node aspect This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets. Fixes bazelbuild#14731 Closes bazelbuild#14730. PiperOrigin-RevId: 480360695 Change-Id: Ic1b9c17ce3af730fa0131f5d87e5ca99ae2740c5
fweikert
pushed a commit
that referenced
this pull request
Oct 20, 2022
*** Reason for rollback *** Due to #16296 (comment) *** Original change description *** Collect implementation_deps in graph node aspect This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets. Fixes #14731 Closes #14730. PiperOrigin-RevId: 480360695 Change-Id: Ic1b9c17ce3af730fa0131f5d87e5ca99ae2740c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for implementation_deps of cc_library targets to be linked into cc_binary targets with dynamic_deps and cc_shared_library targets.
Fixes #14731