Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield a Proxy for addresses without protocol #14897

Closed

Conversation

adamawolf
Copy link
Contributor

Addresses #14896

@meteorcloudy
Copy link
Member

@adamawolf Thanks for the PR, have you tested this actually work?

@coeuvre Can you also take a look, I don't have much experience with proxy.

@adamawolf
Copy link
Contributor Author

@meteorcloudy yes, confirmed this fixes our issue. A couple devs in our company have been using my debug build as their daily-driver and now have no problems with running bazel commands while connected to Proxyman.

Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in f7d8288 Mar 2, 2022
@brentleyjones
Copy link
Contributor

@bazel-io fork 5.1

brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Mar 4, 2022
Addresses bazelbuild#14896

Closes bazelbuild#14897.

PiperOrigin-RevId: 431949154
(cherry picked from commit f7d8288)
Wyverald pushed a commit that referenced this pull request Mar 4, 2022
Addresses #14896

Closes #14897.

PiperOrigin-RevId: 431949154
(cherry picked from commit f7d8288)

Co-authored-by: Adam Wolf <adam.wolf@robinhood.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants