Do not hide BulkTransferException messages when there were more than one exception #14981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception Previously, when there were more than one BulkTransferException, it would be reported like this: ``` Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer ``` which didn't include the underlying exception messages. The only case that underlying exceptions were included was when there was only one exception. This change patches the error message to include all the exception messages, which helps diagnose BulkTransferException.
thii
force-pushed
the
do-not-hide-bulktransferexception-messages-when-there-were-more-than-one
branch
from
158f4f9
to
8c1b84c
Compare
coeuvre
approved these changes
Mar 7, 2022
thii
deleted the
do-not-hide-bulktransferexception-messages-when-there-were-more-than-one
branch
|
@bazel-io fork 5.1 |
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 7, 2022
…one exception Previously, when there were more than one BulkTransferException, it would be reported like this: ``` Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer ``` which didn't include the underlying exception messages. The only case that underlying exceptions were included was when there was only one exception. This change patches the error message to include all the exception messages, which helps diagnose BulkTransferException. Closes bazelbuild#14981. PiperOrigin-RevId: 432921283 (cherry picked from commit 113eaca)
Wyverald
pushed a commit
that referenced
this pull request
Mar 7, 2022
…one exception (#14986) Previously, when there were more than one BulkTransferException, it would be reported like this: ``` Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer ``` which didn't include the underlying exception messages. The only case that underlying exceptions were included was when there was only one exception. This change patches the error message to include all the exception messages, which helps diagnose BulkTransferException. Closes #14981. PiperOrigin-RevId: 432921283 (cherry picked from commit 113eaca) Co-authored-by: Thi Doan <t@thi.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when there were more than one BulkTransferException, it
would be reported like this:
which didn't include the underlying exception messages. The only case
that underlying exceptions were included was when there was only one
exception.
This change patches the error message to include all the exception
messages, which helps diagnose BulkTransferException.