Backport of compilation fix for macOS in abseil-cpp #15169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains the first half of the commit refrenced below, needed to be able to compile bazel on the latest stable macOS toolchain abseil/abseil-cpp@702cae1
nresare
force-pushed
the
fix_grpc_macos_compilation
branch
from
ad9208f
to
9265a60
Compare
sgowroji
added
the
team-OSS
|
Instead of patching grpc, we can just override the abseil version in Bazel. |
|
Closing in favor of #15177 |
|
Oh, that is obviously the better solution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the first half of the commit refrenced below, needed to
be able to compile bazel on the latest stable macOS toolchain
abseil/abseil-cpp@702cae1
Closes #15168