Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify fixedEnv/inheritedEnv interaction in ActionEnvironment #15170

Closed
wants to merge 1 commit into from
Closed

Specify fixedEnv/inheritedEnv interaction in ActionEnvironment #15170

wants to merge 1 commit into from

Commits on Apr 4, 2022

  1. Specify fixedEnv/inheritedEnv interaction in ActionEnvironment 

    Previously, ActionEnvironment did not publicly document how fixed and
inherited environment variables interact, but still cautioned users to
keep the two sets disjoint without enforcing this. As a result, neither
could users rely on the interaction nor could ActionEnvironment benefit
from the additional freedom of not specifying the behavior.

With this commit, ActionEnvironment explicitly specifies that the values
of environment variable inherited from the client environment take
precedence over fixed values and codifies this behavior in a test.
This has been the effective behavior all along and has the advantage
that users can provide overrideable defaults for environment variables.
    @fmeum
    fmeum committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3fff4b9 View commit details
    Browse the repository at this point in the history