Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Starlark executable rules specify their environment #15232

Closed
wants to merge 2 commits into from
Closed

Let Starlark executable rules specify their environment #15232

wants to merge 2 commits into from

Commits on May 4, 2022

  1. Let Starlark executable rules specify their environment 

    The new RunEnvironmentInfo provider allows any executable or test
Starlark rule to specify the environment for when it is executed, either
as part of a test action or via the run command.

Refactors testing.TestEnvironment to construct a RunEnvironmentInfo and
adds a warning (but not an error) if the provider constructed in this
way is returned from a non-executable non-test rule. If a
RunEnvironmentInfo is constructed directly via the Starlark constructor,
this warning becomes an error.
    @fmeum
    fmeum committed May 4, 2022
    Configuration menu
    Copy the full SHA
    88c4e0c View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @fmeum
    fmeum committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9dfd5e5 View commit details
    Browse the repository at this point in the history