Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fixes incorrect install names on darwin platforms" #15450

Merged
merged 1 commit into from
May 10, 2022
Merged

Revert "Fixes incorrect install names on darwin platforms" #15450

merged 1 commit into from
May 10, 2022

Commits on May 10, 2022

  1. Revert "Fixes incorrect install names on darwin platforms" 

    This reverts commit b06f495.

Also had to add a missing mnemonic function call parameter to `getDynamicLibrarySoname`. Copy-pasted the parameter from the other use of that function in the codebase.

Tested manually with a custom toolchain and there is also a test from the reverted code.

Fixes #15214

Closes #15261.

PiperOrigin-RevId: 446662219
    @det @ckolli5
    det authored and ckolli5 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8a2bd25 View commit details
    Browse the repository at this point in the history