Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and test for null value bug when using --repo_env #15618

Closed
wants to merge 3 commits into from
Closed

Fix and test for null value bug when using --repo_env #15618

wants to merge 3 commits into from

Conversation

SalmaSamy
Copy link
Contributor

@SalmaSamy SalmaSamy commented Jun 3, 2022 •
edited
Loading

Fix and test for null value bug when using --repo_env
Issue Link

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jun 6, 2022
meteorcloudy
meteorcloudy approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@meteorcloudy
Copy link
Member

Can you add some description about this PR? What bugs it is trying to fix? The link to the original issue.

@meteorcloudy
Copy link
Member

@bazel-io fork 5.3.0

@bazel-io bazel-io mentioned this pull request Jun 28, 2022
Closed
@meteorcloudy meteorcloudy changed the title Add repo env test Fix and test for null value bug when using --repo_env Jun 28, 2022
This was referenced Jun 29, 2022
Merged
Closed
ckolli5 added a commit that referenced this pull request Jul 5, 2022
@ckolli5
Add repo env test (#15768)
d4663a1 
Fix and test for null value bug when using --repo_env
[Issue Link](#15430)

Closes #15618.

PiperOrigin-RevId: 457728307
Change-Id: I3d57ae4ac95de09215281bec51329b7baafd53af

Co-authored-by: Googler <noreply@google.com>
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SalmaSamy @meteorcloudy @sgowroji @ShreeM01