Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netrc support to --bes_backend #15956

Closed
wants to merge 4 commits into from
Closed

Add netrc support to --bes_backend #15956

wants to merge 4 commits into from

Conversation

ckolli5
Copy link

@ckolli5 ckolli5 commented Jul 22, 2022

Progress on #15856

Fixes #15928

Closes #15930.

PiperOrigin-RevId: 462379746
Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a

@Yannic @ckolli5
Add netrc support to --bes_backend
69ee2d9 
Progress on bazelbuild#15856

Fixes bazelbuild#15928

Closes bazelbuild#15930.

PiperOrigin-RevId: 462379746
Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a
@ckolli5 ckolli5 requested a review from ShreeM01 as a code owner July 22, 2022 21:29
@tjgq
Copy link
Contributor

tjgq commented Jul 25, 2022

@ckolli5 I believe we need to replace BESOptionsT with OptionsT in BuildEventServiceModule.java, as this parameter got renamed in bf002a8.

@meteorcloudy
Copy link
Member

@tjgq In case there are some other missing commits, can you send a PR to release-5.3.0 branch and ask @ckolli5 for review?

@ckolli5 ckolli5 closed this Jul 26, 2022
@ShreeM01 ShreeM01 added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreeM01 ShreeM01 Awaiting requested review from ShreeM01

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ckolli5 @tjgq @meteorcloudy @ShreeM01 @Yannic