Verify gRPC cache downloads after flushing the output. #16072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure any internal buffers (especially compression) are flushed before attempting verify the digest of the downloaded file.
sgowroji
added
team-Remote-Exec
coeuvre
approved these changes
Aug 10, 2022
|
Does this fix any known bug? Is it worth cherry-picking into 5.3? |
|
I am not aware of any bugs this fixes. but should be easy to cherry-pick into 5.3 if time allows. |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
ShreeM01
removed
the
awaiting-review
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
Make sure any internal buffers (especially compression) are flushed before attempting verify the digest of the downloaded file. Closes bazelbuild#16072. PiperOrigin-RevId: 468432319 Change-Id: I9d991d563c232113fe29921580f4964c603faf58
|
This should be in 6.0, removing the "potential release blocker" label. |
meteorcloudy
removed
the
potential release blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure any internal buffers (especially compression) are flushed before attempting verify the digest of the downloaded file.