Add RunfilesLibraryInfo provider #16077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
runfiles-library-info
branch
from
91ca218
to
a7c97f6
Compare
fmeum
force-pushed
the
runfiles-library-info
branch
from
a7c97f6
to
06f3f8e
Compare
sgowroji
added
team-OSS
The new Starlark-defined RunfilesLibraryInfo provider may be used in the future to decide whether additional information has to be emitted by a rule for a target to find its runfiles at runtime. This may include serializing repository mapping information to a runfile and/or generating code that provides the canonical name of the current repository. The provider is added now rather than later so that third-party runfiles libraries can rely on it being present earlier - they have to wait for their minimum supported Bazel version to offer it. If it should turn out not to be needed, it can safely be removed before any ruleset would have a reason to depend on it. Work towards bazelbuild/proposals#269
fmeum
force-pushed
the
runfiles-library-info
branch
from
06f3f8e
to
b7b1a94
Compare
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@oquenchil I just realized that it might be problematic for builtins to access a provider defined in |
|
Hi @fmeum! This PR is in draft state, Can you please provide an update on this since we are very close to our release date. Thanks! |
|
@kshyanashree I am stuck and looking for feedback from @oquenchil. If I don't get this done in time, please just ignore this PR. |
sgowroji
removed
the
potential release blocker
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Starlark-defined RunfilesLibraryInfo provider may be used in the
future to decide whether additional information has to be emitted by a
rule for a target to find its runfiles at runtime. This may include
serializing repository mapping information to a runfile and/or
generating code that provides the canonical name of the current
repository.
The provider is added now rather than later so that third-party runfiles
libraries can rely on it being present earlier - they have to wait for
their minimum supported Bazel version to offer it. If it should turn out
not to be needed, it can safely be removed before any ruleset would have
a reason to depend on it.
Work towards bazelbuild/proposals#269