Fix bazel hanging when outputs got evicted from remote execution cache with --remote_download_toplevel enabled #16423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ShreeM01
added
team-Remote-Exec
|
Thanks! Can you please also add a test for this? |
This was referenced Oct 12, 2022
Closed
|
I created #16464 and included the test there. |
|
Thanks! |
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Nov 22, 2022
Fixes bazelbuild#16422. Closes bazelbuild#16423. Closes bazelbuild#16445. Closes bazelbuild#16464. PiperOrigin-RevId: 480896881 Change-Id: I33019dbe8a088410280759465100a512a0f61bc1
ShreeM01
pushed a commit
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16422 This PR removes ignoring exception from upload task which leads to Bazel hanging in scenario represented in this issue