Remove --experimental_enable_objc_cc_deps #16641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Rules-ObjC
keith
force-pushed
the
ks/remove-experimental_enable_objc_cc_deps
branch
from
aefe1fc
to
66e02c4
Compare
|
@susinmotion have time to check out this small cleanup? |
|
@googlewalt have time for this small cleanup? |
This was flipped in 2017
keith
force-pushed
the
ks/remove-experimental_enable_objc_cc_deps
branch
from
66e02c4
to
2a17cc7
Compare
|
@bazelbuild/triage Can we get someone to review this please? 🙏 |
|
Sorry for the delay. I'll review it. |
brentleyjones
requested review from
googlewalt
and removed request for
susinmotion
googlewalt
approved these changes
Aug 10, 2023
|
Thanks for checking. I will merge it. |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flipped in 2017