fix(rctx.download_and_extract): fix naming convention inconsistencies in rctx.download_and_extract #16757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in rctx.download_and_extract fix naming convention inconsistencies in rctx.download_and_extract for stripPrefix
fmeum
reviewed
Nov 13, 2022
| @@ -572,7 +572,7 @@ public StructImpl download( | |||
| + " \"txz\", \".tar.zst\", \".tzst\", \"tar.bz2\", \".ar\", or \".deb\"" | |||
| + " here."), | |||
| @Param( | |||
| name = "stripPrefix", | |||
| name = "strip_prefix", | |||
There was a problem hiding this comment.
This would break existing users. You could introduce a new parameter with the correct spelling and mark the old one as deprecated.
sgowroji
added
team-ExternalDeps
introduce new parameter for strip_prefix while marking stripPrefix as deprecated
|
@pulanski Can you please check the build failure, it seems more changes are needed for the Java code. |
meteorcloudy
added
awaiting-user-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix naming convention inconsistencies in rctx.download_and_extract for stripPrefix resolving issue #16496