Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs #17017

Closed
wants to merge 1 commit into from
Closed

Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs #17017

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 14, 2022 •
edited

Fixes #17005

@fmeum fmeum marked this pull request as ready for review December 14, 2022 10:17
@fmeum fmeum mentioned this pull request Dec 14, 2022
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 14, 2022

@brandjon

@sgowroji sgowroji added team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel awaiting-review PR is awaiting review from an assigned reviewer labels Dec 14, 2022
brandjon
brandjon approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enthusiastic approve. :)

@brandjon
Copy link
Member

Er, that's right, have to merge it internally...

@fmeum fmeum deleted the 17005-fix-json-star-m1 branch December 15, 2022 10:25
@fmeum fmeum mentioned this pull request Dec 15, 2022
Closed
ted-xie pushed a commit to ted-xie/bazel that referenced this pull request Feb 2, 2023
@fmeum @ted-xie
Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs
3f9a586 
Fixes bazelbuild#17005

Closes bazelbuild#17017.

PiperOrigin-RevId: 495539579
Change-Id: Id4b368e847d0570d6b492280f76469398ec8d9a5
ted-xie pushed a commit to ted-xie/bazel that referenced this pull request Feb 2, 2023
@fmeum @ted-xie
Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs
259be0d 
Fixes bazelbuild#17005

Closes bazelbuild#17017.

PiperOrigin-RevId: 495539579
Change-Id: Id4b368e847d0570d6b492280f76469398ec8d9a5
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@fmeum @hvadehra
Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs
d0c314e 
Fixes #17005

Closes #17017.

PiperOrigin-RevId: 495539579
Change-Id: Id4b368e847d0570d6b492280f76469398ec8d9a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandjon brandjon brandjon approved these changes

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

//src/test/java/net/starlark/java/eval:ScriptTest fails on Apple Silicon machines
3 participants
@fmeum @brandjon @sgowroji