Remove dependency on gnu sed #1716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD sed (the default on osx) does not support the -r --regexp-extended flag. Fixes bazelbuild#1651
|
Can one of the admins verify this patch? |
|
@damienmg Pls review or assign. Thx. |
|
jenkins: test this please |
| DOCKER_MAJOR_VERSION=$(echo "$FULL_DOCKER_VERSION" | sed -r 's#^([0-9]+)\..*#\1#') | ||
| DOCKER_MINOR_VERSION=$(echo "$FULL_DOCKER_VERSION" | sed -r 's#^[0-9]+\.([0-9]+).*#\1#') | ||
| DOCKER_MAJOR_VERSION=$(echo "$FULL_DOCKER_VERSION" | awk -F\. '{ print $1 }') | ||
| DOCKER_MINOR_VERSION=$(echo "$FULL_DOCKER_VERSION" | awk -F\. '{ print $2 }') |
There was a problem hiding this comment.
Is this going to be more portable? Is awk more stable than sed?
There was a problem hiding this comment.
Both awk and sed are in POSIX, and would be expected to be present everywhere bazel would run, including busybox. Both awk and sed are present in the bazel codebase, with sed outnumbering awk by a factor of 4.
Is awk more portable/stable then sed? Hard to say. What I can say is that the -r sed option is not portable, so this is an improvement and IMHO clearer to read.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD sed (the default on osx) does not support the -r --regexp-extended flag. Fixes #1651