Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete android_common v25 and references. #17249

Closed

Conversation

rjobredeaux3
Copy link
Contributor

@rjobredeaux3 rjobredeaux3 commented Jan 18, 2023

Related #17036

@sgowroji sgowroji added team-Android Issues for Android team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 19, 2023
@rjobredeaux3 rjobredeaux3 marked this pull request as draft January 19, 2023 04:07
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Is this still draft?

@meteorcloudy
Copy link
Member

Do you have plan to migrate the rest of the android jars to maven_install_android?

@rjobredeaux3
Copy link
Contributor Author

The switch to the new version just happened so I want to wait a few days (probably until next week) to see if issues arise before I delete the old jars. As for the rest of the android jars there are no immediate plans to migrate them, I suspect this will happen as starlarkification of the rules progresses but we don't have a set timeline for this.

@ahumesky
Copy link
Contributor

I believe this is covered by 94d5d53

@ahumesky ahumesky closed this Aug 17, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants