Add support for alias targets to cquery's providers
#17753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gregestren Could you review? @illicitonion Could you check that this fixes the issue? |
sgowroji
added
team-Configurability
When applied to an `alias` target, the `providers` function of `cquery`'s `--output=starlark` mode now returns the providers of the aliased target rather than `None`. This is achieved by moving `getProvidersDict` from `AbstractConfiguredTarget` up to `ConfiguredTarget`.
fmeum
force-pushed
the
17749-cquery-alias-providers
branch
from
117f358
to
32229c2
Compare
|
Worked for me, thanks! |
gregestren
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.2.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 15, 2023
When applied to an `alias` target, the `providers` function of `cquery`'s `--output=starlark` mode now returns the providers of the aliased target rather than `None`. This is achieved by moving `getProvidersDict` from `AbstractConfiguredTarget` up to `ConfiguredTarget`. Fixes bazelbuild#17749 Closes bazelbuild#17753. PiperOrigin-RevId: 516707744 Change-Id: I840588d605e3a64b968a019cf4bf43b56d18f4f5
keertk
added a commit
that referenced
this pull request
Mar 20, 2023
* Add support for alias targets to cquery's `providers` When applied to an `alias` target, the `providers` function of `cquery`'s `--output=starlark` mode now returns the providers of the aliased target rather than `None`. This is achieved by moving `getProvidersDict` from `AbstractConfiguredTarget` up to `ConfiguredTarget`. Fixes #17749 Closes #17753. PiperOrigin-RevId: 516707744 Change-Id: I840588d605e3a64b968a019cf4bf43b56d18f4f5 * Remove extra code --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by: keertk <keerthanakumar@google.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
When applied to an `alias` target, the `providers` function of `cquery`'s `--output=starlark` mode now returns the providers of the aliased target rather than `None`. This is achieved by moving `getProvidersDict` from `AbstractConfiguredTarget` up to `ConfiguredTarget`. Fixes bazelbuild#17749 Closes bazelbuild#17753. PiperOrigin-RevId: 516707744 Change-Id: I840588d605e3a64b968a019cf4bf43b56d18f4f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applied to an
aliastarget, theprovidersfunction ofcquery's--output=starlarkmode now returns the providers of the aliased target rather thanNone.This is achieved by moving
getProvidersDictfromAbstractConfiguredTargetup toConfiguredTarget.Fixes #17749