Wire up PathMapper in more parts of StarlarkCustomCommandLine
#18165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
|
@gregestren @aranguyen This is a small PR that complements #18098, but can be reviewed independently. I started prototyping more based on #18098 and reached a point where path mapping for Java and Starlark actions works in Bazel with the remote, sandboxed and worker strategies. Once #18098, #18156, #18159 and the current PR have been merged, #18155 will have a manageable size for a review and provides tests. |
fmeum
requested review from
gregestren and
aranguyen
and removed request for
sdtwigg
gregestren
approved these changes
May 1, 2023
|
This can be independently merged, too right? |
|
Yes, this can be merged as is, it is orthogonal to the other PR. |
gregestren
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Work towards bazelbuild#6526 Closes bazelbuild#18165. PiperOrigin-RevId: 528966463 Change-Id: I0f9d3a523b616876c3bb3e8acb1455e408750d1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #6526