Support --unix_digest_hash_attribute_name in repository cache
#18221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
awaiting-review
sushain97
force-pushed
the
add-xattr-to-repo-cache
branch
from
1518e04
to
1b3cfe3
Compare
Wyverald
reviewed
May 2, 2023
src/main/java/com/google/devtools/build/lib/bazel/repository/cache/RepositoryCache.java
Outdated
Show resolved
Hide resolved
sushain97
changed the title
--unix_digest_hash_attribute_name in repository cache
sushain97
commented
May 2, 2023
src/main/java/com/google/devtools/build/lib/bazel/repository/cache/RepositoryCache.java
Outdated
Show resolved
Hide resolved
sushain97
force-pushed
the
add-xattr-to-repo-cache
branch
from
46c2c25
to
e188737
Compare
sushain97
force-pushed
the
add-xattr-to-repo-cache
branch
from
740ccee
to
6d01750
Compare
Wyverald
reviewed
May 4, 2023
src/main/java/com/google/devtools/build/lib/bazel/repository/cache/RepositoryCache.java
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/bazel/repository/cache/RepositoryCacheTest.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
May 4, 2023
Wyverald
added
awaiting-PR-merge
coeuvre
requested changes
May 4, 2023
src/main/java/com/google/devtools/build/lib/vfs/inmemoryfs/InMemoryFileInfo.java
Outdated
Show resolved
Hide resolved
|
@coeuvre Thanks for that flag! Does this look better? |
Pavank1992
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
We extend `RepositoryCache` and `DownloadManager` to support pulling checksums from extended attributes. In some example builds, I observe a 5x speedup in repository fetching: https://github.com/sushain97/bazel-faster-fetch-repro. I would like to make `xattrProvider` not-nullable in any context. However, it's not immediately clear how I could thread access to one in the `BazelPackageLoader` context: https://github.com/sushain97/bazel/blob/1518e04579e6a1c966eb8fbf6d65603e0a1d41d5/src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java#L108-L110. Open to any suggestions. Closes bazelbuild#18221. PiperOrigin-RevId: 529730007 Change-Id: Ic06b4585988a6b5c09f61cee68daf1dcdf3e46fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend
RepositoryCacheandDownloadManagerto support pulling checksums from extended attributes. In some example builds, I observe a 5x speedup in repository fetching: https://github.com/sushain97/bazel-faster-fetch-repro.I would like to make
xattrProvidernot-nullable in any context. However, it's not immediately clear how I could thread access to one in theBazelPackageLoadercontext: https://github.com/sushain97/bazel/blob/1518e04579e6a1c966eb8fbf6d65603e0a1d41d5/src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java#L108-L110. Open to any suggestions.