Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message generation of ActionExecutionException #18243

Closed
wants to merge 1 commit into from
Closed

Fix message generation of ActionExecutionException #18243

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 27, 2023 •
edited
Loading

This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 27, 2023
@fmeum fmeum requested a review from meteorcloudy April 27, 2023 19:17
@github-actions github-actions bot added the team-Performance Issues for Performance teams label Apr 27, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 27, 2023

@meteorcloudy Modifying exception messages may have been naive. I noticed that this ended up duplicating messages in other places, e.g. the one emitted by the TEST_SHARD_STATUS_FILE check.

@fmeum fmeum changed the title Fix message generation of ActionExecutionException" Fix message generation of ActionExecutionException Apr 27, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 27, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2023
@fmeum
Fix message generation of ActionExecutionException"
9477edf 
This fixes an issue introduced by commit
f95b80d, which resulted in certain
exception message being printed twice.
@fmeum fmeum force-pushed the fix-action-execution-exception branch from d48f055 to 9477edf Compare April 27, 2023 21:00
@keertk
Copy link
Member

keertk commented Apr 27, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io mentioned this pull request Apr 27, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2023
meteorcloudy
meteorcloudy approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 28, 2023
@fmeum fmeum deleted the fix-action-execution-exception branch April 28, 2023 11:42
@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 28, 2023
@keertk keertk mentioned this pull request Apr 28, 2023
Merged
Wyverald pushed a commit that referenced this pull request Apr 28, 2023
@keertk @fmeum
Fix message generation of ActionExecutionException (#18257)
034f646 
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice.

Closes #18243.

PiperOrigin-RevId: 527848438
Change-Id: Ic0f7a4a0e3bdf07c1c520647dbb4b41d29e05648

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@fmeum @fweikert
Fix message generation of ActionExecutionException
5afbaa1 
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice.

Closes bazelbuild#18243.

PiperOrigin-RevId: 527848438
Change-Id: Ic0f7a4a0e3bdf07c1c520647dbb4b41d29e05648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fmeum @keertk @meteorcloudy @bazel-io @Pavank1992