Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize map-like settings in CoreOptions #18306

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 4, 2023

Keeps the analysis cache around if e.g. --test_env=foo=baz changes to --test_env=foo=bar --test_env=foo=baz.

Fixes #6667

Keeps the analysis cache around if e.g. `--test_env=foo=baz` changes to
`--test_env=foo=bar --test_env=foo=baz`.
@fmeum fmeum requested a review from a team as a code owner May 4, 2023 06:46
@fmeum fmeum requested review from katre and removed request for a team May 4, 2023 06:46
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability Issues for Configurability team labels May 4, 2023
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 4, 2023
@copybara-service copybara-service bot closed this in 4dc5de8 May 8, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 8, 2023
@fmeum fmeum deleted the 6667-normalize-more-settings branch May 8, 2023 17:35
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Keeps the analysis cache around if e.g. `--test_env=foo=baz` changes to `--test_env=foo=bar --test_env=foo=baz`.

Fixes bazelbuild#6667

Closes bazelbuild#18306.

PiperOrigin-RevId: 530192685
Change-Id: I2c2ee95be6635220c847eeee1e9df4baabe5e3af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability Issues for Configurability team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache misses when duplicate identical --test_env values exist
3 participants