-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve --incompatible_disable_native_android_rules usability #18357
Improve --incompatible_disable_native_android_rules usability #18357
Conversation
} | ||
private static final ImmutableSet<PackageIdentifier> STARLARK_MIGRATION_NATIVE_USAGE_ALLOW_LIST = | ||
// Internal package identifiers that are allowed to use the native Android rules until they | ||
// can be fully moved into the rules_andorid Starlark implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/andorid/android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
// can be fully moved into the rules_android Starlark implementation. | ||
ImmutableSet.<PackageIdentifier>builder() | ||
.add( | ||
PackageIdentifier.createUnchecked( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an internal allow list to the
--incompatible_disable_native_android_rules
so that it doesn't error out immediately when evaluating the mobiel-installbazel_tools
targets.bazel/src/tools/android/java/com/google/devtools/build/android/incrementaldeployment/BUILD.tools
Line 3 in 65b49a2
Some example errors that we see when we flip this flag to ensure that all targets are using the Starlark rules instead of the native rules: