Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate examples inside bazelbuild/bazel #18581

Closed
wants to merge 1 commit into from
Closed

Deprecate examples inside bazelbuild/bazel #18581

wants to merge 1 commit into from

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Jun 5, 2023

@limdor limdor marked this pull request as ready for review June 5, 2023 20:48
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 5, 2023
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 6, 2023
@meteorcloudy
Copy link
Member

Examples in under this directories are still used in some integrations tests, so before deleting them we need to figure out whether to keep or how to migrate those integrations tests.

@limdor
Copy link
Contributor Author

limdor commented Jun 6, 2023

Examples in under this directories are still used in some integrations tests, so before deleting them we need to figure out whether to keep or how to migrate those integrations tests.

Thanks for the heads up. I'm experiencing that when trying to remove the cpp example. I saw that is used for tests that are not just to validate that the example works.

@meteorcloudy
Copy link
Member

I saw that is used for tests that are not just to validate that the example works.

Exactly.

@sgowroji
Copy link
Member

sgowroji commented Jun 7, 2023

Hi @meteorcloudy, Since I can see that this PR has been approved, please let me know whether I should proceed with importing it.Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 7, 2023
@meteorcloudy
Copy link
Member

@sgowroji Thanks, let's do it.

@copybara-service copybara-service bot closed this in ca7ec4c Jun 7, 2023
@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 7, 2023
amishra-u pushed a commit to amishra-u/bazel that referenced this pull request Jun 7, 2023
@limdor @amishra-u
Deprecate examples inside bazelbuild/bazel
362c3ed 
See: bazelbuild/examples#201

Closes bazelbuild#18581.

PiperOrigin-RevId: 538469631
Change-Id: Ib0cfc6de5d9f0d2cc4fc045b47c2d8ce5a6b358e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@limdor @meteorcloudy @sgowroji @Pavank1992