Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Error Prone version to 2.20.0 #19066

Closed
wants to merge 3 commits into from
Closed

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jul 25, 2023

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 25, 2023
@keertk keertk added the team-Rules-Java Issues for Java rules label Jul 25, 2023
@keertk keertk requested a review from meteorcloudy July 25, 2023 19:23
@Wyverald
Copy link
Member

Just so that I understand, will we need a new java_tools release after this? Or is it enough to cherry-pick this alone to 6.3.1?

@Wyverald
Copy link
Member

I resolved the merge conflict, but we'll still need to repin the Maven stuff.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 26, 2023
@meteorcloudy
Copy link
Member

Just so that I understand, will we need a new java_tools release after this?

I believe we'll need a new java_tools release. /cc @keertk

For Bazel@6.3.1, just update the java_tools version following the old process.
For Bazel@HEAD, we'll also need a new rules_java release, then update the rules_java version in Bazel.

This was referenced Jul 26, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 26, 2023
@keertk
Copy link
Member

keertk commented Jul 26, 2023

@cushon Can you submit a PR to cherry-pick these particular changes into release-6.3.1? The WORKSPACE file is quite different and maven_install.json doesn't exist in the release branch.

And side note, the java_tools and rules_java releases are complete. In the process of being merged to master and cherry-picked into 6.3.1.

@cushon
Copy link
Contributor Author

cushon commented Jul 26, 2023

And side note, the java_tools and rules_java releases are complete. In the process of being merged to master and cherry-picked into 6.3.1.

To double-check: were those releases done off the main branch, and are being cherry-picked into 6.3.1? I thought the only use of these jars was to bundle them into a java_tools release, so we'd only need to update them on 6.3.1 if java_tools are being build on 6.3.1. Is that the case?

@cushon
Copy link
Contributor Author

cushon commented Jul 26, 2023

Either way, 6.3.1 has already been updated to use Error Prone 2.20.0 (it was out of sync with the main branch): e0c2080. So I don't think anything else is needed there.

@keertk
Copy link
Member

keertk commented Jul 26, 2023

So to clarify, cherry-picking the new java_tools release (#19091) as per #19066 (comment) is sufficient to fix the issue reported in #19054, correct?

@cushon
Copy link
Contributor Author

cushon commented Jul 26, 2023

Yes, I double-checked that the java_tools release in #19091 contains the fix for google/error-prone#3931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants