Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rules_docker with rules_oci on recommended rules page #19123

Closed
wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Jul 28, 2023

I believe it is no longer maintained, so I'm following the process outlined in the Bazel documentation: https://bazel.build/community/recommended-rules#demotion

Here's some data on rules_docker:

rules_oci seems like the replacement.

I believe it is no longer maintained. rules_oci seems like the replacement. I can justify this claim with more data if you like!
@alexeagle alexeagle changed the title Replace rules_docker Replace rules_docker on recommended rules page Jul 28, 2023
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Jul 28, 2023
site/en/rules/index.md Outdated Show resolved Hide resolved
@Wyverald Wyverald changed the title Replace rules_docker on recommended rules page Replace rules_docker with rules_oci on recommended rules page Jul 29, 2023
@Wyverald Wyverald requested review from radvani13 and removed request for gregestren, fweikert and philomathing July 29, 2023 01:09
@alexeagle
Copy link
Contributor Author

A more sweeping suggestion is for the Bazel team to stop curating the "recommended rules" altogether and hand it over to the Rules Authors SIG. I've added this topic to the next SIG meeting (to be held August 8)

@alexeagle
Copy link
Contributor Author

ping @meisterT I think Radhika has handed things to you while she's on PTO. Do you know if anyone operates the "recommended rules" process?

@Wyverald
Copy link
Member

@meisterT is also on vacation (back next week).

In the mean time, my personal opinion is that we should just accept this PR while we decide what to do in general. I'd like @meteorcloudy to sign off on this too.

@Wyverald Wyverald requested review from meteorcloudy and removed request for radvani13 August 15, 2023 21:23
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 17, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants