Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Report remote execution messages as events" #19347

Closed
wants to merge 1 commit into from
Closed

Revert "Report remote execution messages as events" #19347

wants to merge 1 commit into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Aug 28, 2023

Since it makes it harder for BEP consumers to present the messages in a structured way.

Fixes #19327.

This reverts commit 6d089b3.

@coeuvre coeuvre requested a review from a team as a code owner August 28, 2023 12:16
@coeuvre coeuvre requested a review from tjgq August 28, 2023 12:16
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Aug 28, 2023
@coeuvre coeuvre mentioned this pull request Aug 29, 2023
Closed
@coeuvre
Revert "Report remote execution messages as events"
3150069 
Since it makes it harder for BEP consumers to present the messages in a structured way.

Fixes bazelbuild#19327.

This reverts commit 6d089b3.
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 31, 2023
@copybara-service copybara-service bot closed this in d3d167f Sep 5, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 5, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 5, 2023
@coeuvre @iancha1992
Revert "Report remote execution messages as events"
bd44672 
Since it makes it harder for BEP consumers to present the messages in a structured way.

Fixes bazelbuild#19327.

This reverts commit 6d089b3.

Closes bazelbuild#19347.

PiperOrigin-RevId: 562793125
Change-Id: I6ea41323c4ea98d416e4cfd9728d0d753aef9b5e
@iancha1992 iancha1992 mentioned this pull request Sep 5, 2023
Merged
iancha1992 added a commit that referenced this pull request Sep 6, 2023
@iancha1992 @coeuvre
[6.4.0] Revert "Report remote execution messages as events" (#19415)
4eb2ba6 
Since it makes it harder for BEP consumers to present the messages in a
structured way.

Fixes #19327.

This reverts commit 6d089b3.

Closes #19347.

Commit
d3d167f

PiperOrigin-RevId: 562793125
Change-Id: I6ea41323c4ea98d416e4cfd9728d0d753aef9b5e

Co-authored-by: Chi Wang <chiwang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdSchouten EdSchouten EdSchouten approved these changes

@tjgq tjgq Awaiting requested review from tjgq

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
2 participants
@coeuvre @EdSchouten