Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade zlib to 1.3. #19352

Closed
wants to merge 1 commit into from
Closed

Upgrade zlib to 1.3. #19352

wants to merge 1 commit into from
+16,123 −17,032

Conversation

benjaminp
Copy link
Collaborator

No description provided.

@benjaminp benjaminp marked this pull request as ready for review August 28, 2023 18:04
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 28, 2023
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Aug 30, 2023
@meteorcloudy
Copy link
Member

Can you also update src/MODULE.tools? Thanks!

@meteorcloudy meteorcloudy added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Sep 5, 2023
meteorcloudy
meteorcloudy approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

copybara-service bot pushed a commit that referenced this pull request Sep 5, 2023
@benjaminp @iancha1992
Upgrade zlib to 1.3.
b29649f 
Partial commit for third_party/*, see #19352.

Signed-off-by: Hee Cha <heec@google.com>
@copybara-service copybara-service bot closed this in cd9f8e0 Sep 6, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 6, 2023
@meteorcloudy
Copy link
Member

I think I'm hitting #17956 again with Xcode 14.3 after upgrading to zlib 1.3.

Maybe need to apply meteorcloudy@62ea9dd again or #17956 (comment)

@meteorcloudy
Copy link
Member

Using

    copts = select({
        "@platforms//os:windows": [],
        "//conditions:default": [
            "-Wno-deprecated-non-prototype",
            "-Wno-unused-variable",
            "-Wno-implicit-function-declaration",
        ],
    }),

fixes the issue

@meteorcloudy meteorcloudy mentioned this pull request Sep 6, 2023
Closed
@benjaminp benjaminp deleted the zlib-1.3 branch September 6, 2023 14:10
@iancha1992
Copy link
Member

Third party changes merged at b29649f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjaminp @meteorcloudy @iancha1992 @sgowroji